Conversation
Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools PR 13307, specifically updating the npm link verification logic to better handle npm package URLs. The changes improve upon the previous simple regex replacement with a more robust pattern matching approach that correctly transforms both versioned and non-versioned npmjs.com URLs to their corresponding registry.npmjs.org API endpoints.
Key Changes:
- Enhanced npm link transformation to properly handle versioned URLs (e.g.,
/package/name/v/1.1.0) - Added support for non-versioned package URLs with proper handling of query parameters and fragments
- Improved code clarity with explicit conditional logic and comprehensive inline documentation
weshaggard
approved these changes
Dec 11, 2025
azure-sdk
deleted the
sync-eng/common-copilot/update-npm-url-replacement-logic-13307
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13307 See eng/common workflow